Add better broccoli-side-watch package #2141
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have the
broccoli-side-watch
on themain
branch only, as such there are only0.0.2-unstable.xxx
versions released. That version is only able to watch for explicitly passed folders, which is inconvenient when you want to watch for other packages (addons) in a monorepo, as you need to hard-code (or resolve programatically) the actual folders on disk (/path/to/addon/dist
), but what you rather want is an easy way to just list the package names, similar to what ember-auto-import'swatchDependencies
option does.So this PR is
stable
branchshared-internals
, which allows us to get the optimal watched directory given a package name, taking package.json#exports into account (e.g. watching only./dist
for common v2 addons, instead of the whole package folder including./src
). The plan would be to remove these utils from eai and import frrmshared-internals
once released.